Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement min return fee per byte for CCMs #8170

Merged
merged 14 commits into from
Feb 27, 2023

Conversation

mitsuaki-u
Copy link
Contributor

What was the problem?

This PR resolves #8147

How was it solved?

Added minReturnFeePerByte to schemas, types, commands.

How was it tested?

Added and updated existing unit tests

@mitsuaki-u mitsuaki-u self-assigned this Feb 21, 2023
@mitsuaki-u mitsuaki-u added this to the Sprint 89 milestone Feb 21, 2023
@sitetester sitetester added the framework/module/interoperability Interoperability module label Feb 21, 2023
@shuse2 shuse2 removed this from the Sprint 89 milestone Feb 21, 2023
@shuse2 shuse2 removed the framework/module/interoperability Interoperability module label Feb 21, 2023
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the comments from @sitetester , one more comment

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #8170 (ec9161a) into development (6d3611a) will increase coverage by 0.00%.
The diff coverage is 94.11%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #8170   +/-   ##
============================================
  Coverage        82.75%   82.76%           
============================================
  Files              578      578           
  Lines            21114    21128   +14     
  Branches          3078     3084    +6     
============================================
+ Hits             17473    17486   +13     
- Misses            3641     3642    +1     
Impacted Files Coverage Δ
...erability/mainchain/commands/register_sidechain.ts 100.00% <ø> (ø)
framework/src/modules/interoperability/schemas.ts 100.00% <ø> (ø)
...erability/sidechain/commands/register_mainchain.ts 100.00% <ø> (ø)
...rc/modules/interoperability/stores/channel_data.ts 86.66% <ø> (ø)
...s/interoperability/base_interoperability_method.ts 90.00% <90.00%> (ø)
.../interoperability/base_cc_commands/registration.ts 92.45% <100.00%> (+0.29%) ⬆️
...nteroperability/base_cross_chain_update_command.ts 98.79% <100.00%> (+<0.01%) ⬆️
...interoperability/base_interoperability_endpoint.ts 98.21% <100.00%> (ø)
...ramework/src/modules/interoperability/constants.ts 100.00% <100.00%> (ø)

@mitsuaki-u mitsuaki-u requested a review from ishantiw February 24, 2023 13:17
@ishantiw ishantiw merged commit 265246e into development Feb 27, 2023
@ishantiw ishantiw deleted the 8147_min_return_fee_per_byte branch February 27, 2023 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply changes to interoperability module to add min return fee per byte
5 participants