This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update validators from DPoS module - Closes #6876 #6878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
force-pushed
the
6876-dpos_update_validator
branch
from
51a388a to
cf9de86
Compare
- Migrate _updateValidators function to new DPoS module - Migrate corresponding tests - Migrate necessary util functions
shuse2
force-pushed
the
6876-dpos_update_validator
branch
from
cf9de86 to
20b061e
Compare
mehmetegemen
reviewed
Nov 5, 2021
| isCurrentlyPunished, | ||
| selectStandbyDelegates, | ||
| shuffleDelegateList, | ||
| validtorsEqual, |
| } | ||
| const result: Buffer[] = []; | ||
| const index = pickStandByDelegate(delegateWeights, randomSeed1); | ||
| const [selected] = delegateWeights.splice(index, 1); |
There was a problem hiding this comment.
if the below is secondStandby maybe we can call this firstStandby?
| forgerSelectionZeroStandbyScenario, | ||
| forgerSelectionOneStandbyScenario, | ||
| forgerSelectionTwoStandbyScenario, | ||
| forgerSelectionLessTHan103Scenario, |
| ]; | ||
| const defaultRound = 5; | ||
|
|
||
| for (const scenario of scenarios) { |
There was a problem hiding this comment.
Can't we use describe.each here?
There was a problem hiding this comment.
I think we can, but i would keep it like this for now. I just copied from the existing test =)
mitsuaki-u
approved these changes
Nov 5, 2021
Base automatically changed from
6875-create_voteweight_snapshot
to
feature/6554-improve-framework-architecture
November 5, 2021 13:59
mehmetegemen
approved these changes
Nov 5, 2021
…/github.com/LiskHQ/lisk-sdk into 6876-dpos_update_validator
…/github.com/LiskHQ/lisk-sdk into 6876-dpos_update_validator
shuse2
force-pushed
the
6876-dpos_update_validator
branch
from
2224e06 to
23448b9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6876
How was it solved?
Migrated from
How was it tested?
Migrate tests from previous dpos