This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Add API for Random Module - Closes #6779 #6860
Merged
shuse2
merged 12 commits into
feature/6554-improve-framework-architecture
from
6779-add-api-rand-module
Oct 25, 2021
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cd1b814
π± Add random module utils
ishantiw 51d3bcb
π± Add randomModule API
ishantiw c734169
β
Add unit test for randomModule API
ishantiw c7a5b5b
β
Fix test for isSeedRevealValid
ishantiw 7863630
Merge branch 'feature/6554-improve-framework-architecture' into 6779-β¦
ishantiw 46a3206
π₯ Remove constant RANDOM_SEED_BYTE_SIZE
ishantiw 57838e4
π
Rename util funcs
ishantiw 4ccb5ea
Merge branch '6779-add-api-rand-module' of https://github.com/LiskHQ/β¦
ishantiw de2a46e
β»οΈ Reject negative height and numberOfSeeds value for getRandomSeed
ishantiw 6bba550
β»οΈ Pass BlockAsset to isSeedRevealValid API
ishantiw b369b74
β
Add test when block asset is undefined
ishantiw 189a847
π₯ Remove BIG_ENDIAN as its by default
ishantiw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this? (maybe with better naming)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can improve this later, I copied this function from other place, it better to resolve it in a separate issue. Also, we can move to common utils if we find more usage of this func