Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement DPoS module Endpoint & API - Closes #6720 #6719 #6833

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Implement DPoS module Endpoint & API - Closes #6720 #6719 #6833

merged 4 commits into from
Oct 15, 2021

Conversation

Incede
Copy link
Contributor

@Incede Incede commented Oct 14, 2021 •
edited
Loading

What was the problem?

This PR resolves #6720 #6719

How was it solved?

  • Implement module endpoints as per specification
  • Implement module api as per specification

How was it tested?

Added unit tests

@Incede Incede requested a review from shuse2 October 14, 2021 07:44
@Incede Incede self-assigned this Oct 14, 2021
@Incede Incede changed the title Implement DPoS module Endpoint - Closes #6720 Implement DPoS module Endpoint & API - Closes #6720 #6719 Oct 14, 2021
@Incede Incede requested a review from mehmetegemen October 14, 2021 12:56
shuse2
shuse2 suggested changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! some minor comments

framework/src/modules/dpos_v2/api.ts Outdated Show resolved Hide resolved
framework/src/modules/dpos_v2/api.ts Show resolved Hide resolved
framework/src/modules/dpos_v2/endpoint.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/dpos_v2/api.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/dpos_v2/endpoint.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/dpos_v2/endpoint.spec.ts Outdated Show resolved Hide resolved
@Incede Incede requested a review from shuse2 October 15, 2021 11:11
shuse2
shuse2 approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job =)

@shuse2 shuse2 merged commit ca95690 into feature/6554-improve-framework-architecture Oct 15, 2021
@shuse2 shuse2 deleted the 6720-dpos-endpoint branch October 15, 2021 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@mehmetegemen mehmetegemen mehmetegemen approved these changes

Assignees

@Incede Incede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Incede @shuse2 @mehmetegemen