Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement DPOS utility functions - Closes #6728 #6806

Merged
merged 10 commits into from
Oct 1, 2021
Merged

Implement DPOS utility functions - Closes #6728 #6806

merged 10 commits into from
Oct 1, 2021

Conversation

mitsuaki-u
Copy link
Contributor

What was the problem?

This PR resolves #6728

How was it solved?

  • Added functions:
getMinPunishedHeight
getPunishmentPeriod
getMinWaitingHeight
getWaitingPeriod
isNullCharacterIncluded
isUsername
validateSignature
isCurrentlyPunished
  • Updated dpos v2 types
  • Updated dpos v2 constants

How was it tested?

Functions to be tested in hooks issues.

@mitsuaki-u mitsuaki-u self-assigned this Sep 30, 2021
@mitsuaki-u mitsuaki-u requested a review from shuse2 September 30, 2021 09:29
@shuse2 shuse2 requested a review from mehmetegemen September 30, 2021 09:35
shuse2
shuse2 suggested changes Sep 30, 2021
View reviewed changes
framework/src/modules/dpos_v2/types.ts Outdated Show resolved Hide resolved
framework/src/modules/dpos_v2/types.ts Outdated Show resolved Hide resolved
@shuse2 shuse2 merged commit e8d0332 into feature/6554-improve-framework-architecture Oct 1, 2021
@shuse2 shuse2 deleted the 6728_dpos_utils branch October 1, 2021 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@mehmetegemen mehmetegemen mehmetegemen approved these changes

Assignees

@mitsuaki-u mitsuaki-u

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitsuaki-u @shuse2 @mehmetegemen