This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add reward module endpoint - Closes #6689 #6751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
suggested changes
Sep 8, 2021
shuse2
approved these changes
Sep 8, 2021
ishantiw
suggested changes
Sep 8, 2021
Reward calculation logic will also be used by the API. We prefered config injection to endpoint and then passing injected configs to separated function instead of passing a function to endpoint that is bound to config variables. That way we preserved type safety and flexibility of using config vars later in the different places of the endpoint.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6689
How was it solved?
getDefaultRewardAtHeightfunction and injected necessary configs for itHow was it tested?