Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add reward module initials - Closes #6687 #6712

Conversation

mehmetegemen
Copy link
Contributor

What was the problem?

This PR resolves #6687

How was it solved?

  • Added required files for further development
  • Created the class and bound dependencies to it

How was it tested?

  • Manually checked files

@mehmetegemen mehmetegemen requested a review from shuse2 September 3, 2021 08:26
@mehmetegemen mehmetegemen self-assigned this Sep 3, 2021
@shuse2 shuse2 requested a review from mitsuaki-u September 3, 2021 08:27
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing but looks good to me

$id: '/reward/config',
type: 'object',
properties: {
tokenIDReward: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to have required field for chainID and localID

@shuse2 shuse2 requested review from ishantiw and mitsuaki-u and removed request for mitsuaki-u and ishantiw September 3, 2021 09:03
Copy link
Contributor

@mitsuaki-u mitsuaki-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides @shuse2 's comment

@shuse2 shuse2 merged commit 3468e44 into feature/6554-improve-framework-architecture Sep 3, 2021
@shuse2 shuse2 deleted the 6687-reward-module-initials branch September 3, 2021 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants