This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add genesis block and bootstrap handling for dpos and bft - Closes #5281 and #5282 #5469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
suggested changes
Jun 26, 2020
| @@ -84,6 +90,8 @@ export class Dpos { | |||
| this.delegateActiveRoundLimit = 3; | |||
| this.chain = chain; | |||
| this.rounds = new Rounds({ | |||
| genesisHeight, | |||
| initRound, | |||
| blocksPerRound: this._delegatesPerRound, | |||
There was a problem hiding this comment.
I notice or used somewhere else as roundLength we should be consistent. If required can create an issue to make these consistent.
janhack
reviewed
Jun 26, 2020
janhack
reviewed
Jun 26, 2020
janhack
reviewed
Jun 26, 2020
janhack
reviewed
Jun 26, 2020
…bft to initialize finalized height with genesis height
nazarhussain
suggested changes
Jun 29, 2020
nazarhussain
approved these changes
Jun 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5281 and resolves #5282
Main changes are
How was it solved?
How was it tested?