Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update blockId to use full SHA256 - Closes #5176 #5315

Merged
merged 18 commits into from
May 12, 2020

Conversation

ishantiw
Copy link
Contributor

@ishantiw ishantiw commented May 7, 2020

What was the problem?

This PR resolves #5176

How was it solved?

  • Update getBlockId function to use SHA256
  • Add db migration file for blockId and previousBlockId changes
  • Update schema and the snapshot to accept maxlength of 64 and of hex format
  • Fix tests

How was it tested?

node framework/test/test_app

@ishantiw ishantiw self-assigned this May 7, 2020
@ishantiw ishantiw requested a review from shuse2 May 7, 2020 17:38
@shuse2 shuse2 requested a review from IkerAlus May 11, 2020 07:47
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishantiw ishantiw force-pushed the 5176_update_blockid_sha256 branch from a109aff to 27c965a Compare May 11, 2020 13:27
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor adjustment

elements/lisk-chain/src/schema.ts Show resolved Hide resolved
@ishantiw ishantiw force-pushed the 5176_update_blockid_sha256 branch from 726fcdd to 139a223 Compare May 12, 2020 11:06
@ishantiw ishantiw requested a review from shuse2 May 12, 2020 11:07
@ishantiw ishantiw force-pushed the 5176_update_blockid_sha256 branch from ee85f32 to 4c3b02e Compare May 12, 2020 13:52
@shuse2 shuse2 merged commit 604c576 into development May 12, 2020
@shuse2 shuse2 deleted the 5176_update_blockid_sha256 branch May 12, 2020 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update blockID to use full SHA-256 hash
3 participants