This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Update blockId to use full SHA256 - Closes #5176 #5315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IkerAlus
approved these changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ishantiw
force-pushed
the
5176_update_blockid_sha256
branch
from
May 11, 2020 13:27
a109aff
to
27c965a
Compare
shuse2
suggested changes
May 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor adjustment
ishantiw
force-pushed
the
5176_update_blockid_sha256
branch
from
May 12, 2020 11:06
726fcdd
to
139a223
Compare
ishantiw
force-pushed
the
5176_update_blockid_sha256
branch
from
May 12, 2020 13:52
ee85f32
to
4c3b02e
Compare
shuse2
approved these changes
May 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5176
How was it solved?
How was it tested?
node framework/test/test_app