Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix fail to start test app - Closes #5306 #5307

Merged
merged 1 commit into from
May 6, 2020
Merged

Fix fail to start test app - Closes #5306 #5307

merged 1 commit into from
May 6, 2020

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented May 6, 2020

What was the problem?

This PR resolves #5306

How was it solved?

  • Fix the input parameter name
  • Fix several eslint issues
  • Remove Processor and Syncchronizer types and use the real one

How was it tested?

  • There should be no eslint issue
  • Run the test_app after building

@shuse2 shuse2 requested review from ManuGowda and ishantiw May 6, 2020 10:33
@shuse2 shuse2 self-assigned this May 6, 2020
@shuse2 shuse2 merged commit b63ef95 into feature/5182-update_framework_typescript May 6, 2020
@shuse2 shuse2 deleted the 5306-fix_fail_application branch May 6, 2020 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ishantiw ishantiw ishantiw approved these changes

@ManuGowda ManuGowda ManuGowda approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuse2 @ManuGowda @ishantiw