Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update application/node/forger to be typescript - Closes #5190 #5304

Merged

Conversation

ManuGowda
Copy link
Contributor

What was the problem?

This PR resolves #5190

How was it solved?

  • Migrated forger to typescript
  • Updated unit and integration tests

How was it tested?

  • Run framework unit and integration tests

@ManuGowda ManuGowda self-assigned this May 5, 2020
@ManuGowda ManuGowda requested review from ishantiw and shuse2 May 5, 2020 09:38
@ManuGowda ManuGowda linked an issue May 5, 2020 that may be closed by this pull request
framework/src/application/node/forger/forger.ts Outdated Show resolved Hide resolved
framework/src/application/node/forger/forger.ts Outdated Show resolved Hide resolved
framework/src/application/node/forger/forger.ts Outdated Show resolved Hide resolved
framework/src/application/node/forger/forger.ts Outdated Show resolved Hide resolved
framework/src/application/node/forger/forger.ts Outdated Show resolved Hide resolved
framework/src/application/node/forger/forger.ts Outdated Show resolved Hide resolved
framework/src/application/node/forger/forger.ts Outdated Show resolved Hide resolved
framework/src/application/node/forger/forger.ts Outdated Show resolved Hide resolved
framework/src/application/node/forger/forger.ts Outdated Show resolved Hide resolved
framework/src/application/node/forger/forger.ts Outdated Show resolved Hide resolved
@ManuGowda ManuGowda requested a review from shuse2 May 5, 2020 10:28
@ManuGowda ManuGowda force-pushed the 5190-update-forger-module branch from c06aafc to 0e59a7f Compare May 5, 2020 10:43
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments

framework/src/application/node/forger/forger.ts Outdated Show resolved Hide resolved
framework/src/application/node/forger/forger.ts Outdated Show resolved Hide resolved
@ManuGowda ManuGowda requested a review from ishantiw May 5, 2020 13:14
@ManuGowda ManuGowda force-pushed the 5190-update-forger-module branch from 8afe069 to 8348ad8 Compare May 5, 2020 13:41
@ManuGowda ManuGowda requested a review from ishantiw May 5, 2020 14:17
@ManuGowda ManuGowda force-pushed the 5190-update-forger-module branch from 931d219 to 71546ef Compare May 5, 2020 16:21
@ManuGowda ManuGowda merged commit 86e5424 into feature/5182-update_framework_typescript May 5, 2020
@ManuGowda ManuGowda deleted the 5190-update-forger-module branch May 5, 2020 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update application/node/forger to be typescript
3 participants