This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Update application/node/forger to be typescript - Closes #5190 #5304
Merged
ManuGowda
merged 9 commits into
feature/5182-update_framework_typescript
from
5190-update-forger-module
May 5, 2020
Merged
Update application/node/forger to be typescript - Closes #5190 #5304
ManuGowda
merged 9 commits into
feature/5182-update_framework_typescript
from
5190-update-forger-module
May 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
suggested changes
May 5, 2020
ManuGowda
force-pushed
the
5190-update-forger-module
branch
from
May 5, 2020 10:43
c06aafc
to
0e59a7f
Compare
shuse2
approved these changes
May 5, 2020
ishantiw
reviewed
May 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few comments
ishantiw
reviewed
May 5, 2020
ManuGowda
force-pushed
the
5190-update-forger-module
branch
from
May 5, 2020 13:41
8afe069
to
8348ad8
Compare
ishantiw
approved these changes
May 5, 2020
ManuGowda
force-pushed
the
5190-update-forger-module
branch
from
May 5, 2020 16:21
931d219
to
71546ef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5190
How was it solved?
How was it tested?
unit and integration
tests