Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove verifyCommon for CCU transaction verify #8258

Closed
ishantiw opened this issue Mar 13, 2023 · 1 comment
Closed

Remove verifyCommon for CCU transaction verify #8258

ishantiw opened this issue Mar 13, 2023 · 1 comment
Assignees
@mitsuaki-u
Labels
framework/module/interoperability Interoperability module type: refactoring

Comments

@ishantiw
Copy link
Contributor

Description

Since mainchain CCU update transaction verify function is not using verifyCommon anymore. We can remove this function and move the functionality to verify of sidechain CCU update transaction verify function as its not common anymore.

Acceptance Criteria

  • Update all the relevant unit tests
  • Should pass all the unit tests

Additional Information
@ishantiw ishantiw mentioned this issue Mar 13, 2023
Merged
@mitsuaki-u mitsuaki-u self-assigned this Mar 13, 2023
@Madhulearn Madhulearn added this to the Sprint 91 milestone Mar 14, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 91, Sprint 92 Mar 27, 2023
@ishantiw
Copy link
Contributor Author

ishantiw commented Apr 5, 2023

Resolved in #8258

@ishantiw ishantiw closed this as completed Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mitsuaki-u mitsuaki-u

Labels
framework/module/interoperability Interoperability module type: refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ishantiw @mitsuaki-u @Madhulearn