Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update genesis state handling for DPoS module #7669

Closed
Tracked by #7622
shuse2 opened this issue Oct 19, 2022 · 0 comments
Closed
Tracked by #7622

Update genesis state handling for DPoS module #7669

shuse2 opened this issue Oct 19, 2022 · 0 comments
Assignees
@shuse2
Labels
framework
Milestone
Sprint 81

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Oct 19, 2022 •
edited
Loading

Description

  • Update initGenesisState/finalizeGenesisState hooks to the LIP.
    • Update validation regarding the reward sharing
    • Check current implementations in initGenesisState/finalizeGenesisState hooks are aligned with LIP
  • Update genesis block in dpos mainchain example
  • Update commander/src/utils/genesis_creation.ts to align with the genesis block

Acceptance Criteria

  • Update unit tests to support the changes
  • Ensure dpos mainchain example app runs and generate block
  • Check commander init function generates valid application which can run

Additional Information

To create genesis block in example app,

./bin/run genesis-block:create --output config/default --assets-file ./config/default/genesis_assets.json
@shuse2 shuse2 moved this to Backlog in Lisk SDK Version 6.0.0 Oct 19, 2022
@shuse2 shuse2 mentioned this issue Oct 19, 2022
Closed
18 tasks
@shuse2 shuse2 added this to the Sprint 81 milestone Oct 24, 2022
@shuse2 shuse2 mentioned this issue Nov 3, 2022
Merged
shuse2 added a commit that referenced this issue Nov 7, 2022
@shuse2
Update genesis state handling for DPoS (#7730)
8614063 
### What was the problem?

This PR resolves #7669 

### How was it solved?

- Add validation for the reward sharing in initGenesisState
- Update BFT property calculation in finalizeGenesisState
- Update Remove snapshot usage in finalizeGenesisState
- Add new properties to init command genesis creation
- Update genesis block in example

### How was it tested?

- Run DPoS example app
- Add additional test for validations
@shuse2 shuse2 self-assigned this Nov 7, 2022
@shuse2 shuse2 closed this as completed Nov 7, 2022
Repository owner moved this from Backlog to Done in Lisk SDK Version 6.0.0 Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
framework
Projects
None yet
Milestone
Sprint 81
Development

No branches or pull requests
1 participant
@shuse2