Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Accept transaction params input from file #7276

Closed
Tracked by #7210
ManuGowda opened this issue Jul 5, 2022 · 0 comments · Fixed by #7327
Closed
Tracked by #7210

Accept transaction params input from file #7276

ManuGowda opened this issue Jul 5, 2022 · 0 comments · Fixed by #7327
Assignees
@mosmartin
Labels
commander type: improvement
Milestone
Sprint 74

Comments

@ManuGowda
Copy link
Contributor

ManuGowda commented Jul 5, 2022 •
edited by ishantiw
Loading

Description

Enable users to provide transaction params input from file.
Update transaction:create command to accept params input from file.

  • Add flag as --file <FILE_PATH> and when the flag is present then expect the params from the file.
  • Only allow one flag either --file or --params

Motivation

  • When transaction params input length longer
    • User would find it difficult to type the input in CLI
    • When transaction params has inputs like initValidators its harder to type/copy paste into CLI with clarity
  • Easy of use

Acceptance

  • Add unit test for params passed as file
@shuse2 shuse2 moved this to Backlog in Lisk SDK Version 6.0.0 Jul 5, 2022
@milenagojkovic milenagojkovic mentioned this issue Jul 6, 2022
Closed
@milenagojkovic milenagojkovic added this to the Sprint 74 milestone Jul 18, 2022
@milenagojkovic milenagojkovic moved this from Backlog to ToDo in Lisk SDK Version 6.0.0 Jul 18, 2022
@mosmartin mosmartin moved this from ToDo to In Progress in Lisk SDK Version 6.0.0 Jul 19, 2022
@mosmartin mosmartin mentioned this issue Jul 20, 2022
Merged
@mosmartin mosmartin moved this from In Progress to Pending Review in Lisk SDK Version 6.0.0 Jul 21, 2022
shuse2 added a commit that referenced this issue Jul 22, 2022
@shuse2
Merge pull request #7327 from LiskHQ/7276-accept-transaction-params-i…
0059547 
…nput-from-file

Accept transaction params input from file - Closes #7276
Repository owner moved this from Pending Review to Done in Lisk SDK Version 6.0.0 Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mosmartin mosmartin

Labels
commander type: improvement
Projects
None yet
Milestone
Sprint 74
Development

Successfully merging a pull request may close this issue.

Accept transaction params input from file - Closes #7276 LiskArchive/lisk-sdk
4 participants
@shuse2 @ManuGowda @milenagojkovic @mosmartin