Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update EventQueue interface and application config #7124

Closed
Tracked by #6950
shuse2 opened this issue Apr 22, 2022 · 0 comments · Fixed by #7157
Closed
Tracked by #6950

Update EventQueue interface and application config #7124

shuse2 opened this issue Apr 22, 2022 · 0 comments · Fixed by #7157
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Apr 22, 2022

Description

  • Update application config is updated to include below property. -1 would mean indefinite.
{
  system: {
    // height of the block, default is 300
    keepEventsForHeights: number,
  },
}
  • Update event queue interface to
interface EventQueue {
  add(moduleID: number, typeID: number, data: Buffer, topics?: Buffer[], noRevert?: boolean);
  // below interface should not be visible to the hook
  createSnapshot(): void;
  restoreSnapshot(): void;
}

where

  • Add function should check size of data to not exceed maximum
  • Add function should check topics has maximum length of 3, and does not contain duplicate of 0x00, 0x01 or transaction ID

Acceptance Criteria

  • Example app should be working
  • All builds and tests are passing
@shuse2 shuse2 mentioned this issue Apr 22, 2022
4 tasks
@shuse2 shuse2 moved this to Backlog in Lisk SDK Version 6.0.0 Apr 22, 2022
@milenagojkovic milenagojkovic added this to the Sprint 69 milestone May 9, 2022
@shuse2 shuse2 moved this from Backlog to Pending Review in Lisk SDK Version 6.0.0 May 9, 2022
shuse2 added a commit that referenced this issue May 13, 2022
Update event definition, event queue and block header - Closes #7124 and #7125
@shuse2 shuse2 moved this from Pending Review to Done in Lisk SDK Version 6.0.0 May 13, 2022
@shuse2 shuse2 closed this as completed May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants