Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix getGeneratorsBetweenTimestamps type and return keys #6892

Closed
Tracked by #6717
shuse2 opened this issue Nov 11, 2021 · 0 comments
Closed
Tracked by #6717

Fix getGeneratorsBetweenTimestamps type and return keys #6892

shuse2 opened this issue Nov 11, 2021 · 0 comments
Assignees
@shuse2
Labels
framework unplanned
Milestone
Sprint 57

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Nov 11, 2021 •
edited
Loading

Description

  • Update the return type to be Record<string, number> to reflect the correct typing
  • Result key should be in binary format than utf8. ie) generatorList.addresses.map(buf => buf.toString('binary')); because some character in Buffer cannot be represented in utf8 format

Acceptance Criteria

  • Update unit test
  • DPoS dependency type should be updated
@shuse2 shuse2 mentioned this issue Nov 11, 2021
Closed
15 tasks
@shuse2 shuse2 changed the title Update getGeneratorsBetweenTimestamps exclude startTimestamp Fix getGeneratorsBetweenTimestamps type and return keys Nov 12, 2021
@shuse2 shuse2 added this to the Sprint 57 milestone Nov 12, 2021
@shuse2 shuse2 self-assigned this Nov 12, 2021
@shuse2 shuse2 mentioned this issue Nov 12, 2021
Merged
shuse2 added a commit that referenced this issue Nov 17, 2021
@shuse2
Merge pull request #6901 from LiskHQ/6629-update_application_class
3fc8507 
Update application class - Closes #6629 and #6892
@shuse2 shuse2 closed this as completed Nov 17, 2021
@shuse2 shuse2 moved this to Done in Lisk SDK Version 6.0.0 Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
framework unplanned
Projects
None yet
Milestone
Sprint 57
Development

No branches or pull requests
1 participant
@shuse2