Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Verify aggregate commit on block verification #6855

Closed
Tracked by #6837
ishantiw opened this issue Oct 19, 2021 · 0 comments
Closed
Tracked by #6837

Verify aggregate commit on block verification #6855

ishantiw opened this issue Oct 19, 2021 · 0 comments
Assignees
@Incede
Labels
framework
Milestone
Spike 3

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Oct 19, 2021 •
edited
Loading

Description

Verify aggregate commit property on block verification step when receive block from the network in consensus. Use verifyAggregateCommit(aggregateCommit) in commitPool to verify which is implemented in #6847.

Call commitPool.verifyAggregateCommit(aggregateCommit) in consensus block validation step.

https://research.lisk.com/t/introduce-certificate-generation-mechanism/296#block-verification-52

Acceptance Criteria

  • Add unit test covering verification of aggregateCommit
@ishantiw ishantiw mentioned this issue Oct 19, 2021
Closed
18 tasks
@shuse2 shuse2 added this to the Sprint 58 milestone Nov 19, 2021
@sridharmeganathan sridharmeganathan removed this from the Sprint 58 milestone Nov 22, 2021
@sridharmeganathan sridharmeganathan added this to the Sprint 59 milestone Dec 6, 2021
@mitsuaki-u mitsuaki-u assigned mitsuaki-u and unassigned mitsuaki-u Dec 16, 2021
@Incede Incede self-assigned this Dec 16, 2021
@milenagojkovic milenagojkovic modified the milestones: Sprint 59, Spike 3 Dec 20, 2021
@Incede Incede mentioned this issue Dec 20, 2021
Merged
Incede added a commit that referenced this issue Dec 29, 2021
@Incede
Merge pull request #6962 from LiskHQ/6855-verify-agg
62513c3 
 Verify aggregate commit on block verification - Closes #6855
@Incede Incede closed this as completed Dec 29, 2021
@shuse2 shuse2 moved this to Done in Lisk SDK Version 6.0.0 Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Incede Incede

Labels
framework
Projects
None yet
Milestone
Spike 3
Development

No branches or pull requests
6 participants
@shuse2 @milenagojkovic @ishantiw @Incede @mitsuaki-u @sridharmeganathan