Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add API for BFT module #6744

Closed
Tracked by #6742
shuse2 opened this issue Sep 7, 2021 · 0 comments · Fixed by #6790
Closed
Tracked by #6742

Add API for BFT module #6744

shuse2 opened this issue Sep 7, 2021 · 0 comments · Fixed by #6790
Assignees
@shuse2
Labels
framework groomed type: improvement
Milestone
Sprint 54

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Sep 7, 2021 •
edited
Loading

Description

Implement BFTAPI in api.ts as defined in https://research.lisk.com/t/introduce-bft-module/321.

areHeadersContradicting
isHeaderContradictingChain
existBFTParameters
getBFTParameters
getBFTHeights
impliesMaximalPrevotes
getNextHeightBFTParameters
setBFTParameters

If API requires access to the state, the first parameter must be apiContext: APIContext; otherwise, the input should follow the specification.

Acceptance Criteria

  • All functions are implemented as specification
  • All functions are fully unit tested

Additional Information

Related to #6742
@shuse2 shuse2 mentioned this issue Sep 7, 2021
Closed
8 tasks
@shuse2 shuse2 self-assigned this Sep 13, 2021
@shuse2 shuse2 modified the milestone: Sprint 53 Sep 13, 2021
@shuse2 shuse2 assigned shuse2 and unassigned shuse2 Sep 13, 2021
@shuse2 shuse2 added this to the Sprint 53 milestone Sep 14, 2021
@shuse2 shuse2 mentioned this issue Sep 20, 2021
Merged
@shuse2 shuse2 linked a pull request Sep 20, 2021 that will close this issue
Add BFT API - Closes #6744 #6790
Merged
shuse2 added a commit that referenced this issue Oct 1, 2021
@shuse2
Merge pull request #6790 from LiskHQ/6744-add_bft_api
030c4ea 
Add BFT API - Closes #6744
@shuse2 shuse2 closed this as completed Oct 1, 2021
@shuse2 shuse2 moved this to Done in Lisk SDK Version 6.0.0 Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
framework groomed type: improvement
Projects
None yet
Milestone
Sprint 54
Development

Successfully merging a pull request may close this issue.

Add BFT API - Closes #6744 LiskArchive/lisk-sdk
2 participants
@shuse2 @sridharmeganathan