Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement afterBlockExecute hook of Rewards Module #6690

Closed
mehmetegemen opened this issue Aug 25, 2021 · 1 comment
Closed

Implement afterBlockExecute hook of Rewards Module #6690

mehmetegemen opened this issue Aug 25, 2021 · 1 comment
Assignees
@mehmetegemen
Labels
framework groomed type: improvement
Milestone
Sprint 53

Comments

@mehmetegemen
Copy link
Contributor

mehmetegemen commented Aug 25, 2021 •
edited by shuse2
Loading

Description

Implement afterBlockExecute hook as specified in https://research.lisk.com/t/define-state-transitions-of-reward-module/316#after-block-execution-22

Acceptance criteria

  • Possible scenarios are tested in the unit test(e.g. BFT violation, seedReveal violation etc.)

Additional Information

  • TOKEN_ID_REWARD will be specified in config parameter of init method of the reward module class.

Related Issue

#6686
@mehmetegemen mehmetegemen mentioned this issue Aug 25, 2021
Closed
@mehmetegemen mehmetegemen changed the title Implement afterBlockExecute hook Implement afterBlockExecute hook of Rewards Module Aug 25, 2021
@shuse2 shuse2 added this to the Sprint 52 milestone Sep 2, 2021
@mehmetegemen
Copy link
Contributor Author

Suspended until assets will be part of the context since we need seedReveal from the assets.

@mehmetegemen mehmetegemen mentioned this issue Sep 17, 2021
Merged
shuse2 added a commit that referenced this issue Sep 17, 2021
@shuse2
Merge pull request #6784 from LiskHQ/6690-reward-after-b-exec
576e9d0 
Implement afterBlockExecute hook for the reward module - Closes #6690
@shuse2 shuse2 closed this as completed Sep 17, 2021
@shuse2 shuse2 moved this to Done in Lisk SDK Version 6.0.0 Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mehmetegemen mehmetegemen

Labels
framework groomed type: improvement
Projects
None yet
Milestone
Sprint 53
Development

No branches or pull requests
3 participants
@shuse2 @mehmetegemen @sridharmeganathan