Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove number of transactions per block validation from lisk-chain and update maxPayloadLength constant #4851

Closed
shuse2 opened this issue Feb 17, 2020 · 0 comments · Fixed by #4884
Closed

Remove number of transactions per block validation from lisk-chain and update maxPayloadLength constant #4851

shuse2 opened this issue Feb 17, 2020 · 0 comments · Fixed by #4884
Assignees
@ishantiw
Labels
elements/chain
Milestone
Sprint 14

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Feb 17, 2020 •
edited
Loading

Description

With the new dynamic fee system, the number of transactions per block check should be removed.

Motivation

Motivation is described in https://github.com/LiskHQ/lips/blob/master/proposals/lip-0013.md

Acceptance Criteria

  • Number of transactions check needs to be removed from elements/lisk-chain/src/validate.ts
  • Remove the related tests
  • Config for setting the number of transactions per block needs to be removed
  • maxTransactionsPerBlock constant needs to be removed in config and constructors in chain
  • maxPayloadLength constant needs to be updated in config and constructors in chain
  • Test exceeding maxPayloadLength
  • Test below maxPayloadLength

Related issues

#4837
@ManuGowda ManuGowda mentioned this issue Feb 17, 2020
Closed
@shuse2 shuse2 changed the title Remove number of transactions per block validation from lisk-chain Remove number of transactions per block validation from lisk-chain and update max payload size constant Feb 17, 2020
@shuse2 shuse2 changed the title Remove number of transactions per block validation from lisk-chain and update max payload size constant Remove number of transactions per block validation from lisk-chain and update maxPayloadLength constant Feb 17, 2020
@sridharmeganathan sridharmeganathan added this to the Next Sprint milestone Feb 24, 2020
@ishantiw ishantiw mentioned this issue Feb 26, 2020
Merged
shuse2 added a commit that referenced this issue Feb 27, 2020
@shuse2
Merge pull request #4884 from LiskHQ/4851_remove_no_of_trx_update_max…
1b97de4 
…payload

Remove numberOfTransactions and maxTransactionsPerBlock - Closes #4851
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ishantiw ishantiw

Labels
elements/chain
Projects
None yet
Milestone
Sprint 14
Development

Successfully merging a pull request may close this issue.

Remove numberOfTransactions and maxTransactionsPerBlock - Closes #4851 LiskArchive/lisk-sdk
3 participants
@shuse2 @ishantiw @sridharmeganathan