✅ Add test when block asset is undefined

LiskArchive · Oct 22, 2021 · b369b74 · b369b74
1 parent 6bba550
commit b369b74
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/framework/src/modules/random/api.ts b/framework/src/modules/random/api.ts
@@ -32,10 +32,14 @@ export class RandomAPI extends BaseAPI {
 			EMPTY_KEY,
 			seedRevealSchema,
 		);
+		const asset = blockAssets.getAsset(this.moduleID);
+		if (!asset) {
+			throw new Error('Block asset is missing.');
+		}
 
 		const { seedReveal } = codec.decode<BlockHeaderAssetRandomModule>(
 			blockHeaderAssetRandomModule,
-			blockAssets?.getAsset(this.moduleID) ?? Buffer.alloc(0),
+			asset,
 		);
 
 		return getSeedRevealValidity(generatorAddress, seedReveal, validatorReveals);

diff --git a/framework/test/unit/modules/random/api.spec.ts b/framework/test/unit/modules/random/api.spec.ts
@@ -72,6 +72,21 @@ describe('RandomModuleAPI', () => {
 			);
 		});
 
+		it('should throw error when asset is undefined', async () => {
+			// Arrange
+			const address = Buffer.from(genesisDelegates.delegates[0].address, 'hex');
+
+			const blockAsset: BlockAsset = {
+				moduleID: randomAPI['moduleID'],
+				data: undefined as any,
+			};
+
+			// Act & Assert
+			await expect(
+				randomAPI.isSeedRevealValid(context, address, new BlockAssets([blockAsset])),
+			).rejects.toThrow('Block asset is missing.');
+		});
+
 		it('should return true for a valid seed reveal', async () => {
 			// Arrange
 			const address = Buffer.from(genesisDelegates.delegates[0].address, 'hex');