Merge pull request #6934 from LiskHQ/6840_sign_certificate

Implement signCertificate for CommitPool - Closes #6840

framework/src/node/consensus/certificate_generation/utils.ts

@@ -12,12 +12,12 @@
  * Removal or modification of this copyright notice is prohibited.
  */
 
+import { signBLS, verifyWeightedAggSig } from '@liskhq/lisk-cryptography';
 import { BlockHeader } from '@liskhq/lisk-chain';
 import { codec } from '@liskhq/lisk-codec';
-import { verifyWeightedAggSig } from '@liskhq/lisk-cryptography';
-import { MESSAGE_TAG_CERTIFICATE } from './constants';
-import { certificateSchema } from './schema';
 import { Certificate } from './types';
+import { certificateSchema } from './schema';
+import { MESSAGE_TAG_CERTIFICATE } from './constants';
 
 export const computeCertificateFromBlockHeader = (blockHeader: BlockHeader): Certificate => {
 	if (!blockHeader.stateRoot) {
@@ -37,13 +37,20 @@ export const computeCertificateFromBlockHeader = (blockHeader: BlockHeader): Cer
 	};
 };
 
-// TODO: https://github.com/LiskHQ/lisk-sdk/issues/6840
 export const signCertificate = (
-	_sk: Buffer,
-	_networkIdentifier: Buffer,
-	_blockHeader: BlockHeader,
-	// eslint-disable-next-line @typescript-eslint/no-empty-function
-): Buffer => Buffer.from('');
+	sk: Buffer,
+	networkIdentifier: Buffer,
+	certificate: Certificate,
+): Buffer => {
+	const { aggregationBits, signature, ...rawCertificate } = certificate;
+
+	return signBLS(
+		MESSAGE_TAG_CERTIFICATE,
+		networkIdentifier,
+		codec.encode(certificateSchema, rawCertificate),
+		sk,
+	);
+};
 
 // TODO: https://github.com/LiskHQ/lisk-sdk/issues/6841
 export const verifySingleCertificateSignature = (

framework/test/unit/node/consensus/certificate_generation/utils.spec.ts

@@ -11,6 +11,7 @@
  *
  * Removal or modification of this copyright notice is prohibited.
  */
+
 import { BlockHeader } from '@liskhq/lisk-chain';
 import {
 	signBLS,
@@ -26,6 +27,7 @@ import { certificateSchema } from '../../../../../src/node/consensus/certificate
 import {
 	verifyAggregateCertificateSignature,
 	computeCertificateFromBlockHeader,
+	signCertificate,
 } from '../../../../../src/node/consensus/certificate_generation/utils';
 import { createFakeBlockHeader } from '../../../../../src/testing';
 
@@ -65,8 +67,35 @@ describe('utils', () => {
 			);
 		});
 	});
+
 	describe('signCertificate', () => {
-		it.todo('');
+		let privateKey: Buffer;
+		let certificate: Certificate;
+		let signature: Buffer;
+
+		beforeEach(() => {
+			privateKey = generatePrivateKey(getRandomBytes(32));
+			certificate = {
+				blockID: Buffer.alloc(0),
+				height: 1000,
+				stateRoot: Buffer.alloc(0),
+				timestamp: 10000,
+				validatorsHash: Buffer.alloc(0),
+			};
+			const encodedCertificate = codec.encode(certificateSchema, certificate);
+			signature = signBLS(
+				MESSAGE_TAG_CERTIFICATE,
+				networkIdentifier,
+				encodedCertificate,
+				privateKey,
+			);
+			(certificate as any).aggregationBits = getRandomBytes(4);
+			(certificate as any).signature = getRandomBytes(4);
+		});
+
+		it('should sign certificate', () => {
+			expect(signCertificate(privateKey, networkIdentifier, certificate)).toEqual(signature);
+		});
 	});
 	describe('verifySingleCertificateSignature', () => {
 		it.todo('');