♻️ Add default asset type as buffer

LiskArchive · May 28, 2020 · 9886e56 · 9886e56
1 parent 2c0e0cf
commit 9886e56
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/elements/lisk-chain/src/data_access/transaction_interface_adapter.ts b/elements/lisk-chain/src/data_access/transaction_interface_adapter.ts
@@ -40,7 +40,7 @@ export class TransactionInterfaceAdapter {
 	}
 
 	// First encode message asset and then encode base message
-	public encode(message: BaseTransaction<{}>): Buffer {
+	public encode(message: BaseTransaction): Buffer {
 		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
 		const TransactionClass = this._transactionClassMap.get(message.type);
 
@@ -59,17 +59,17 @@ export class TransactionInterfaceAdapter {
 	}
 
 	// First decode base message and then decode asset
-	public decode(binaryMessage: Buffer): BaseTransaction<{}> {
+	public decode(binaryMessage: Buffer): BaseTransaction {
 		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-		const baseMessage = codec.decode<BaseTransaction<{}>>(BaseTransaction.BASE_SCHEMA, binaryMessage);
+		const baseMessage = codec.decode<BaseTransaction>(BaseTransaction.BASE_SCHEMA, binaryMessage);
 		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
 		const TransactionClass = this._transactionClassMap.get(baseMessage.type);
 
 		if (!TransactionClass) {
 			throw new Error('Transaction type not found.');
 		}
 		// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-assignment
-		const assetMessage = codec.decode<BaseTransaction<{}>>(TransactionClass.ASSET_SCHEMA, baseMessage.asset as Buffer);
+		const assetMessage = codec.decode<BaseTransaction>(TransactionClass.ASSET_SCHEMA, baseMessage.asset as Buffer);
 		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 		const message = { ...baseMessage, asset: assetMessage };
 

diff --git a/elements/lisk-transactions/src/base_transaction.ts b/elements/lisk-transactions/src/base_transaction.ts
@@ -63,7 +63,7 @@ export interface StateStore {
 export const ENTITY_ACCOUNT = 'account';
 export const ENTITY_TRANSACTION = 'transaction';
 
-export abstract class BaseTransaction<T> {
+export abstract class BaseTransaction<T = Buffer> {
 	public static TYPE: number;
 	// Minimum remaining balance requirement for any account to perform a transaction
 	public static MIN_REMAINING_BALANCE = BigInt('5000000'); // 0.05 LSK