Allow to save and manage multiple accounts in local storage - Closes #573 #966

slaweet · 2017-11-07T08:53:18Z

What was the problem?

There was no tool for managing multiple saved accounts.

How did I fix it?

By creating a component that can:

How to test it?

Review checklist

The PR solves Allow to save and manage multiple accounts in local storage #573
All new code is covered with unit tests
All new features are covered with e2e tests
All new code follows best practices

reyraa · 2017-11-09T15:59:04Z

src/utils/savedAccounts.js

@@ -0,0 +1,41 @@
+export const getSavedAccounts = () => {
+  const savedAccounts = localStorage.getItem('accounts');
+  let accounts = [];


Why do you initiate an array if your going to re-assign it?

reyraa · 2017-11-09T16:00:47Z

src/utils/savedAccounts.js

+  const savedAccounts = localStorage.getItem('accounts');
+  let accounts = [];
+  if (savedAccounts) {
+    accounts = JSON.parse(savedAccounts);


Please check the structure of what you retrieve here, it might be modified to an undesired value. if this returns a non array value ,then your code with fail in line 16

reyraa · 2017-11-09T16:03:06Z

src/utils/savedAccounts.js

+};
+
+export const getLastActiveAccount = () => (
+  getSavedAccounts()[localStorage.getItem('lastActiveAccountIndex') || 0]


What if:

Saved account is an empty array?

lastActiveAccountIndex is modified to a non numeric string?

Then getLastActiveAccount returns undefined

yes, thank you 348f38e fixed it.

reyraa · 2017-11-09T16:25:12Z

src/utils/savedAccounts.js

+  getSavedAccounts()[localStorage.getItem('lastActiveAccountIndex') || 0]
+);
+
+export const setLastActiveAccount = ({ publicKey, network, address }) => {


By convention, methods which set a value, return the new state.
same goes for setSavedAccount

reyraa · 2017-11-09T23:52:20Z

src/components/login/login.js

@@ -127,8 +127,9 @@ class Login extends React.Component {

  autoLogin() {
    const { savedAccounts } = this.props;
-    if (savedAccounts && savedAccounts.length > 0 && !this.props.account.afterLogout) {
-      this.account = savedAccounts[0];
+    console.log('dass', savedAccounts);


please remove

...because it doesn't work on Jenkins

slaweet self-assigned this Nov 7, 2017

slaweet added the 🏗️ in progress label Nov 7, 2017

slaweet force-pushed the 573-multi-account-management branch from 54abcd5 to ec17131 Compare November 8, 2017 14:08

slaweet added 6 commits November 8, 2017 15:12

Create pending e2e tests for multi account management

f1fc075

Add network options to peers state

405996d

Fix account removed reducer to check also network

b03e510

Add accountSwitched action

4093148

Implement multiple account management

c438b92

Remove saveAccountButton and use route directly

097fcd8

slaweet force-pushed the 573-multi-account-management branch from ec17131 to 097fcd8 Compare November 8, 2017 14:12

Fix and enable saved accounts e2e tests

0732679

slaweet requested review from reyraa and yasharAyari November 9, 2017 08:21

Rename saveAccount to savedAccounts

04921d1

slaweet force-pushed the 573-multi-account-management branch from 24127d0 to 04921d1 Compare November 9, 2017 13:56

slaweet added 2 commits November 9, 2017 15:38

Implement the "Remember last account" feature

83d92c8

Add unit tests for savedAccounts middleware

aab4ee4

slaweet force-pushed the 573-multi-account-management branch from 1d6d6e2 to aab4ee4 Compare November 9, 2017 15:12

slaweet added 4 commits November 9, 2017 16:17

Add missing unit test for savedAccounts actions

c48244b

Fix unit test coverage of SavedAccountsHOC

0dbd61c

Move savedAccounts css from js file

f686b47

Improve unit test coverage of SavedAccounts component

3461c07

slaweet force-pushed the 573-multi-account-management branch from a1d1073 to 3461c07 Compare November 9, 2017 15:58

Fix save second account e2e test

696d816

reyraa suggested changes Nov 9, 2017

View reviewed changes

Refactor savedAccounts util

348f38e

slaweet added 👁️ pending review and removed 🏗️ in progress labels Nov 9, 2017

reyraa reviewed Nov 9, 2017

View reviewed changes

Remove forgotten console.log

4170b7b

Repository owner deleted a comment from slaweet Nov 10, 2017

Repository owner deleted a comment from ginacontrino Nov 10, 2017

Repository owner deleted a comment from slaweet Nov 10, 2017

slaweet added 3 commits November 10, 2017 11:16

Handle invalid accounts in localStorage

d30aa0c

Add unit tests for savedAccounts utils

0f4ce7b

Unify parameter names of savedAccounts actions

93e3be3

slaweet force-pushed the 573-multi-account-management branch from 7649b1e to 93e3be3 Compare November 10, 2017 14:37

Merge branch '1.3.0' into 573-multi-account-management

72ca0b9

slaweet force-pushed the 573-multi-account-management branch from cb7ce36 to 72ca0b9 Compare November 10, 2017 15:23

reyraa previously approved these changes Nov 10, 2017

View reviewed changes

Make "switch accounts" e2e scenario temporarily pending

1f7128b

...because it doesn't work on Jenkins

slaweet dismissed reyraa’s stale review via 1f7128b November 13, 2017 14:14

reyraa approved these changes Nov 13, 2017

View reviewed changes

slaweet merged commit bb863f4 into 1.3.0 Nov 13, 2017

slaweet deleted the 573-multi-account-management branch November 13, 2017 14:35

slaweet added ✅ ready and removed 👁️ pending review labels Nov 13, 2017

slaweet mentioned this pull request Nov 30, 2017

Improve saveAccount utility code #774

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow to save and manage multiple accounts in local storage - Closes #573 #966

Allow to save and manage multiple accounts in local storage - Closes #573 #966

slaweet commented Nov 7, 2017 •

edited

Loading

reyraa Nov 9, 2017

reyraa Nov 9, 2017

reyraa Nov 9, 2017

slaweet Nov 9, 2017

reyraa Nov 9, 2017

reyraa Nov 9, 2017

slaweet Nov 9, 2017

reyraa Nov 9, 2017

Allow to save and manage multiple accounts in local storage - Closes #573 #966

Allow to save and manage multiple accounts in local storage - Closes #573 #966

Conversation

slaweet commented Nov 7, 2017 • edited Loading

What was the problem?

How did I fix it?

How to test it?

Review checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slaweet commented Nov 7, 2017 •

edited

Loading