Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Refactor i18n - Closes #892 #951

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Refactor i18n - Closes #892 #951

merged 1 commit into from
Nov 3, 2017

Conversation

ginacontrino
Copy link
Contributor

@ginacontrino ginacontrino commented Nov 3, 2017

What was the problem?

We had 2 different setups of i18n (one for electron, one for the web version) that could share one setup file

How did I fix it?

Put language related things into a directory 'i18n' that can be shared

How to test it?

  • Run tests
  • Make sure the translations are still working

Review checklist

Unverified

No user is associated with the committer email.
@ginacontrino ginacontrino requested a review from slaweet November 3, 2017 13:12
@ginacontrino ginacontrino self-assigned this Nov 3, 2017
@slaweet slaweet changed the title Refactor i18n Refactor i18n - Closes #892 Nov 3, 2017
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@slaweet slaweet merged commit 84f6864 into 1.3.0 Nov 3, 2017
@slaweet slaweet deleted the 892-i18n-setups branch November 3, 2017 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants