This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Retain votes after cleaned search box - Closes #916 #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the issue?
Presently we keep the search term in Redux store, but at the time of developing this component we just kept vote list, delegates list and refresh flag. So now changes in the search term cause unintended trigger of
loadVotedDelegates.How did I solve?
Instead of listening for changes of properties, I check if
refreshDelegateshas been changed fromfalsetotrue.There are some other minor code cleanups in this PR.
Closes #916