Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Add missing error toast for unavailable custom node - Closes #879 #880

Merged
merged 4 commits into from
Oct 18, 2017
Merged

Add missing error toast for unavailable custom node - Closes #879 #880

merged 4 commits into from
Oct 18, 2017

Conversation

ginacontrino
Copy link
Contributor

What's the problem?
There was no error toast when trying to connect to an unavailable custom node
#879

What did you do?

  • I added a missing catch to then display the toast
  • Added e2e test

screen shot 2017-10-17 at 11 45 25

@ginacontrino ginacontrino self-assigned this Oct 17, 2017
@ginacontrino ginacontrino requested a review from slaweet October 17, 2017 09:49
@ginacontrino ginacontrino changed the base branch from 1.2.0 to development October 17, 2017 15:00
@ginacontrino ginacontrino changed the base branch from development to 1.2.0 October 17, 2017 15:00
slaweet
slaweet approved these changes Oct 18, 2017
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Gina.

@ginacontrino ginacontrino merged commit 83c07ad into 1.2.0 Oct 18, 2017
@ginacontrino ginacontrino deleted the 879-custom-node-error-toast branch October 18, 2017 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slaweet slaweet slaweet approved these changes

Assignees

@ginacontrino ginacontrino

Labels
✅ ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ginacontrino @slaweet