This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Make outgoing transactions black instead of red - Closes #658 #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
suggested changes
Sep 29, 2017
| @@ -15,7 +15,7 @@ const Amount = (props) => { | |||
| params.className = 'inButton'; | |||
| } else if (props.value.type !== transactionTypes.send || | |||
| props.value.recipientId !== props.address) { | |||
| params.className = 'outButton'; | |||
There was a problem hiding this comment.
outButton represents the action/role, while grayButton represents the state which likely to change, just like what you've one here. I'd rather keep outBbutton
There was a problem hiding this comment.
Do you mean that the className should stay outButton here but be changed in css file to have the new look?
slaweet
force-pushed
the
658-avoid-red-for-good-transactions
branch
from
4ce226a to
29348bb
Compare
reyraa
approved these changes
Oct 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #658