This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Use local storage instead of cookies #687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loeck
commented
Aug 30, 2017
src/components/login/loginForm.js
Outdated
| const passphrase = Cookies.get('passphrase'); | ||
| const network = parseInt(Cookies.get('network'), 10) || 0; | ||
| const address = localStorage.getItem('address') || ''; | ||
| const passphrase = localStorage.getItem('passphrase') || ''; |
There was a problem hiding this comment.
The || '' it's only for avoid null in <Input /> (because localStorage.getItem return null if value not exist)
|
Hi @Lohek, it's nice of you to contribute to Lisk and your code is sound, but please respect when an issue is assigned to someone. You can ask on our Gitter: https://gitter.im/LiskHQ/lisk if you want to work on some issue. |
|
Aww sorry, i work on this before the assignment... and after that, i don't check ^^' |
|
I assigned the issue when creating it. I've opened my PR which also fixes e2e test to make Jenkins pass and I'm closing this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #681