Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Delegate list gets slow when loading ~1000 delegates - Closes #260 #644

Merged
merged 7 commits into from
Aug 28, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Aug 24, 2017

Closes #260

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.
It's dirty when its selected flag was changed
This speeds up the delegate selection considerably.

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.
Copy link
Contributor

@yasharAyari yasharAyari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when an user add or remove a vote in voteAutocomplete inputs in vote confirm modal list of delegates won't update.

Unverified

The committer email address is not verified.
const { data } = props;
return (<TableRow {...props} className={`${styles.row} ${setRowClass(data)}`}>
class VotingRow extends React.Component {
shouldComponentUpdate(nextProps) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line cause an eslint error.

Unverified

The committer email address is not verified.
Copy link
Contributor

@yasharAyari yasharAyari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job.

@slaweet slaweet merged commit ea7c975 into development Aug 28, 2017
@slaweet slaweet deleted the 260-delegates-list-slow branch August 28, 2017 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants