-
Notifications
You must be signed in to change notification settings - Fork 60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer an overlaying layer (Fixed positioned over all elements) to hinder all user interaction and not apply all these changes.
The thing is we don't want to disable all interactions. Definitely not "Logout" button |
Now that I'm thinking about it "SIgn/verify message" has no problem with being offline, so it should be available |
But for the migration, I think the current implementation is fine and there can be an "enhancement" issue later on to "Provide a better offline experience". |
Ok, let me describe in more details. These said, we can simply add a class name to buttons/menu items which require the active peer to disable them by CSS later on when the body tag, has a class name of |
I'm all for "a more informative UX approach". But the goal of this PR is merely migrating the functionality from Angular. |
The reason I don't approve your implementation is:
Please change the offlineWrapper to just manipulate a class name and not add any layers to the existing structure. thanks. |
And then each element that should be disabled wheen offline gets a css class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Vit. Good job!
Closes #545