This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Migrate global loading bar to React - Closes #494 #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
494-global-loading-bar
branch
from
f6e4daf to
0b3b485
Compare
yasharAyari
suggested changes
Aug 1, 2017
| /* eslint-disable */ | ||
| export const requestToActivePeer = (activePeer, path, urlParams) => | ||
| new Promise((resolve, reject) => { | ||
| loadingStarted(path); |
There was a problem hiding this comment.
I think we should use loading actions inside our component instead of using them inside our api utils
yasharAyari
approved these changes
Aug 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #494