This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Re-enable e2e tests for features already working in React - Closes #507 #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
507-re-enable-e2e-tests
branch
from
287d9d5 to
b26c49c
Compare
slaweet
force-pushed
the
507-re-enable-e2e-tests
branch
from
a98c4d6 to
f0111e8
Compare
slaweet
force-pushed
the
507-re-enable-e2e-tests
branch
from
f0111e8 to
99e7836
Compare
yasharAyari
reviewed
Jul 28, 2017
| <Link to={`${match.url}/transactions`}>Transactions</Link> | ||
| <Link to={`${match.url}/voting`}>Voting</Link> | ||
| <Link to={`${match.url}/forging`}>Forging</Link> | ||
| <section className='main-tabs'> |
There was a problem hiding this comment.
I think it is better to use nav tag instead of section here.
There was a problem hiding this comment.
Good point. But not worth fixing because it will be replaced with <Tabs> in #505 anyway.
reyraa
suggested changes
Jul 28, 2017
features/menu.feature
Outdated
| @@ -82,29 +81,25 @@ Feature: Top right menu | |||
| -----END LISK SIGNED MESSAGE----- | |||
| """ | |||
|
|
|||
| @ignore | |||
| Scenario: should allow to exit sign message dialog | |||
There was a problem hiding this comment.
Please reflect the difference of this test with the next one in their titles
features/menu.feature
Outdated
| @@ -82,29 +81,25 @@ Feature: Top right menu | |||
| -----END LISK SIGNED MESSAGE----- | |||
| """ | |||
|
|
|||
| @ignore | |||
| Scenario: should allow to exit sign message dialog | |||
| Given I'm logged in as "any account" | |||
| When I click "sign message" in main menu | |||
| And I click "cancel button" | |||
There was a problem hiding this comment.
When I remove this line, I expect the test to fail, but it passes. apparently this line doesn't affect the test result.
Same goes for the next 2 scenarios testing x and cancel buttons close our sign and verify message dialogs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #507