This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Create <LiskAmount val={val} /> React component - Closes #501 #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
suggested changes
Jul 21, 2017
| import { mount } from 'enzyme'; | ||
| import LiskAmount from './'; | ||
|
|
||
| describe('<LiskAmount />', () => { |
There was a problem hiding this comment.
Please remove HTML annotations
|
|
||
| describe('<LiskAmount />', () => { | ||
| const normalizeNumber = 100000000; | ||
| it('should render "12932689.645" as "12,932,689.645"', () => { |
There was a problem hiding this comment.
Please use a more descriptive title. I'd suggest:
should normalize "12932689.645" as "12,932,689.645"
reyraa
suggested changes
Jul 21, 2017
There was a problem hiding this comment.
Overall seems good. thank you.
There's just one point. There're requests for adding other currencies. to take the possibility of adding other currencies into account, I asked Yashar to keep it's normaliser (FormattedNumber) free of lisk name.
so we can use the same component for (for example) showing USD.
Please use a more global name for files and components
reyraa
approved these changes
Jul 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #501