Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Minor ui fixes #334

Merged
merged 4 commits into from
Jun 7, 2017
Merged

Minor ui fixes #334

merged 4 commits into from
Jun 7, 2017

Conversation

alepop
Copy link
Contributor

@alepop alepop commented Jun 6, 2017

This PR closes #332, closes #333, and closes #329.

Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#333, and #329 look good.

In #332, the globaly defined .fee class breaks transactions table .fee class. It would be good to have .fee defined globally (index.less?) but maybe name it differently to prevent the collision with transactions .fee.
In vote dialog I have the fee over 'Confirm vote' button

@slaweet
Copy link
Contributor

slaweet commented Jun 7, 2017

@alepop also please next time make one PR per issue with descriptive title, it makes easier to see what issues have an open PR and what we should work on.

@slaweet slaweet self-assigned this Jun 7, 2017
@alepop
Copy link
Contributor Author

alepop commented Jun 7, 2017

@slaweet I grouped this small fixes for convenience for preventing branch spam. I understood you and will not do it again.
The good method to prevent style class name collision is using CSS modules.

@slaweet slaweet merged commit 63b03da into LiskArchive:development Jun 7, 2017
@karmacoma karmacoma changed the title minor ui fixes Minor ui fixes Jun 8, 2017
@karmacoma karmacoma added the bug label Jun 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants