Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

UI fixes #306

Merged
merged 3 commits into from
Jun 1, 2017
Merged

UI fixes #306

merged 3 commits into from
Jun 1, 2017

Conversation

alepop
Copy link
Contributor

@alepop alepop commented Jun 1, 2017

Resolve #296, #297, #298, #302

Copy link
Contributor

@reyraa reyraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the minor change I've requested, all good! Thank you

@@ -12,16 +12,16 @@ div.dialog-send(aria-label='Send funds')
div(ng-messages='$ctrl.transferForm.recipient.$error')
div(ng-message='required') Required
div(ng-message='pattern') Invalid
div(layout="row")
md-input-container.md-block.flex-95
div(style={'position': 'relative'})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use inline styling.

Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now.

@reyraa reyraa merged commit ccca3b3 into LiskArchive:development Jun 1, 2017
@slaweet
Copy link
Contributor

slaweet commented Jun 1, 2017

@alepop next time you Resolve multiple issues in one PR, it needs to specify with each explicitly:
https://help.github.com/articles/closing-issues-via-commit-messages/#closing-multiple-issues

@alepop
Copy link
Contributor Author

alepop commented Jun 1, 2017

@slaweet ok. I don't know about this feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants