Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Keep selected network on new account cancellation - Closes #280 #291

Merged
merged 7 commits into from
Jun 2, 2017
Merged

Keep selected network on new account cancellation - Closes #280 #291

merged 7 commits into from
Jun 2, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented May 31, 2017 •
edited by karmacoma
Loading

Closes #280

@slaweet slaweet added the bug label May 31, 2017
@slaweet slaweet self-assigned this May 31, 2017
@slaweet slaweet requested a review from reyraa May 31, 2017 14:13
reyraa
reyraa suggested changes Jun 1, 2017
View reviewed changes
Copy link
Contributor

@reyraa reyraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we use cookies to store the last actively selected network, not only we fix this issue but also it's easier for the user not to have to change network every time.

@slaweet slaweet force-pushed the 280-persist-network-on-new-account branch from f7f60c7 to 8600887 Compare June 1, 2017 10:34
@slaweet
Copy link
Contributor Author

slaweet commented Jun 2, 2017

@reyraa I added saving network to cookies, but I'm saving it only after successful login - not to save some invalid address.

@slaweet slaweet merged commit 3231e43 into development Jun 2, 2017
@slaweet slaweet deleted the 280-persist-network-on-new-account branch June 2, 2017 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reyraa reyraa reyraa approved these changes

Assignees

@slaweet slaweet

Labels
✅ ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slaweet @reyraa @karmacoma