Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Send from address or amount - Closes #270 #271

Merged
merged 10 commits into from
May 30, 2017

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented May 29, 2017

Provides the functionality of showing send dialog with pre-filled values of address and/or amount by clicking on address or amount in transaction items and also by clicking on account balance.

@reyraa reyraa requested a review from slaweet May 29, 2017 12:48
lsk.value(amount='transaction.amount')
md-tooltip(md-direction='top', md-delay='350', data-ng-if='transaction.amount > 0') Send {{transaction.amount}} LSK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tooltip shows wrong value, e.g. Send 3000000000 LSK instead of Send 30 LSK

td(md-cell)
i.material-icons(ng-if='transaction.type === 0 && transaction.senderId === transaction.recipientId') replay
i.material-icons.in(ng-if='transaction.senderId !== $ctrl.account.get().address') call_received
i.material-icons.out(ng-if='transaction.type !== 0 || transaction.recipientId !== $ctrl.account.get().address') call_made
td(md-cell)
.amount(ng-class='{ neutral:transaction.type === 0 && transaction.senderId === transaction.recipientId, positive: transaction.senderId !== $ctrl.account.get().address, negative: transaction.type !== 0 || transaction.recipientId !== $ctrl.account.get().address }')
.amount(ng-class='{"has-send-modal": transaction.amount > 0, neutral:transaction.type === 0 && transaction.senderId === transaction.recipientId, positive: transaction.senderId !== $ctrl.account.get().address, negative: transaction.type !== 0 || transaction.recipientId !== $ctrl.account.get().address }',
data-show-send-modal, data-amount='transaction.amount')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected this would set also , data-recipient-id='transaction.recipientId'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I had in mind was to send the same amount not repeating the transaction. But I'm open to change it if you think that's gonna be more useful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think 'repeat transactions' is more useful. But even that is probably still a rare case at the current state of Lisk.

.amount(ng-class='{ neutral:transaction.type === 0 && transaction.senderId === transaction.recipientId, positive: transaction.senderId !== $ctrl.account.get().address, negative: transaction.type !== 0 || transaction.recipientId !== $ctrl.account.get().address }')
.amount(data-ng-if='transaction.type !== 0 || transaction.recipientId !== $ctrl.account.get().address',
data-ng-class='{"has-send-modal": transaction.amount > 0}',
data-show-send-modal, data-amount='transaction.amount', data-recipient-id='transaction.recipientId', class='negative')
Copy link
Contributor

@slaweet slaweet May 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class='negative' should be .negative after .amount
Similarly in 3 other places in this file

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants