-
Notifications
You must be signed in to change notification settings - Fork 60
Send from address or amount - Closes #270 #271
Conversation
…sue with sending floating point values
… clicking on them
lsk.value(amount='transaction.amount') | ||
md-tooltip(md-direction='top', md-delay='350', data-ng-if='transaction.amount > 0') Send {{transaction.amount}} LSK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tooltip shows wrong value, e.g. Send 3000000000 LSK
instead of Send 30 LSK
td(md-cell) | ||
i.material-icons(ng-if='transaction.type === 0 && transaction.senderId === transaction.recipientId') replay | ||
i.material-icons.in(ng-if='transaction.senderId !== $ctrl.account.get().address') call_received | ||
i.material-icons.out(ng-if='transaction.type !== 0 || transaction.recipientId !== $ctrl.account.get().address') call_made | ||
td(md-cell) | ||
.amount(ng-class='{ neutral:transaction.type === 0 && transaction.senderId === transaction.recipientId, positive: transaction.senderId !== $ctrl.account.get().address, negative: transaction.type !== 0 || transaction.recipientId !== $ctrl.account.get().address }') | ||
.amount(ng-class='{"has-send-modal": transaction.amount > 0, neutral:transaction.type === 0 && transaction.senderId === transaction.recipientId, positive: transaction.senderId !== $ctrl.account.get().address, negative: transaction.type !== 0 || transaction.recipientId !== $ctrl.account.get().address }', | ||
data-show-send-modal, data-amount='transaction.amount') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected this would set also , data-recipient-id='transaction.recipientId'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I had in mind was to send the same amount not repeating the transaction. But I'm open to change it if you think that's gonna be more useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think 'repeat transactions' is more useful. But even that is probably still a rare case at the current state of Lisk.
.amount(ng-class='{ neutral:transaction.type === 0 && transaction.senderId === transaction.recipientId, positive: transaction.senderId !== $ctrl.account.get().address, negative: transaction.type !== 0 || transaction.recipientId !== $ctrl.account.get().address }') | ||
.amount(data-ng-if='transaction.type !== 0 || transaction.recipientId !== $ctrl.account.get().address', | ||
data-ng-class='{"has-send-modal": transaction.amount > 0}', | ||
data-show-send-modal, data-amount='transaction.amount', data-recipient-id='transaction.recipientId', class='negative') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class='negative'
should be .negative
after .amount
Similarly in 3 other places in this file
Provides the functionality of showing send dialog with pre-filled values of address and/or amount by clicking on address or amount in transaction items and also by clicking on account balance.