Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Refactor e2e tests to multitple files and use cucumber - Closes #202 #252

Merged
merged 7 commits into from
May 23, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented May 22, 2017

Also:

  • migrates jasmine assertions to chai (and chai-as-promissed) to be consistent with unit tests
  • sets a unique class to each element used in e2e tests

@slaweet slaweet self-assigned this May 22, 2017
@slaweet slaweet requested a review from reyraa May 22, 2017 13:47
@reyraa
Copy link
Contributor

reyraa commented May 22, 2017

Please consider pushing changes in multiple commits since some of them are applying different changes.

@slaweet slaweet force-pushed the 202_cucumber-for-e2e branch from a5de464 to 09d9228 Compare May 22, 2017 14:09
@slaweet
Copy link
Contributor Author

slaweet commented May 22, 2017

@alihaghighatkhah, I split it to 5 commits.

reyraa
reyraa previously approved these changes May 22, 2017
Copy link
Contributor

@reyraa reyraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @slaweet !

@slaweet slaweet force-pushed the 202_cucumber-for-e2e branch from 3f4b8f7 to 100ead1 Compare May 23, 2017 07:35
@slaweet slaweet requested a review from reyraa May 23, 2017 08:57
@slaweet slaweet force-pushed the 202_cucumber-for-e2e branch from 100ead1 to 6006755 Compare May 23, 2017 08:57
@slaweet slaweet merged commit 2b00967 into development May 23, 2017
@slaweet slaweet deleted the 202_cucumber-for-e2e branch May 23, 2017 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants