This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Fix forging tab visibility - Closes #218 #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
suggested changes
May 17, 2017
| username: data.delegate.username, | ||
| }); | ||
| }).catch(() => { | ||
| $timeout(checkPendingRegistration, 10000); |
There was a problem hiding this comment.
Please use Sync service instead of timeout
src/app/components/login/login.js
Outdated
| @@ -57,7 +57,9 @@ app.component('login', { | |||
| passphrase: this.Passphrase.normalize(_passphrase), | |||
| network: this.network, | |||
| }); | |||
| this.$state.go(this.$rootScope.landingUrl || 'main.transactions'); | |||
| this.$state.go(this.$rootScope.landingUrl && this.$rootScope.landingUrl !== 'main.forging' ? | |||
There was a problem hiding this comment.
Please remove this part and make sure the message in src/app/components/forging/forging.pug will be shown if the user is not delegate or the registration is not confirmed,
src/app/components/main/main.js
Outdated
| @@ -65,6 +65,9 @@ app.component('main', { | |||
| isDelegate: true, | |||
| username: data.delegate.username, | |||
| }); | |||
| if (this.$rootScope.landingUrl === 'main.forging') { | |||
This reverts commit 8fb50d2.
... because forging center was broken in that case
reyraa
approved these changes
May 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #218