Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Unify naming conventions - Closes #179 #199

Merged
merged 17 commits into from
May 10, 2017

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented May 10, 2017

  • Split Account service into:
    • Account service taking care of account information.
    • AccountApi service managing account related Api calls.
  • Change all use cases of Send to Transfer.
  • Move delegate service and forging service and peer under services/api directory.
  • Rename $peers service to Peers.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 90.376% when pulling de281aa on 179-angular-service-naming into c70678b on development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 90.269% when pulling 043b955 on 179-angular-service-naming into ce6ee4d on development.

@slaweet
Copy link
Contributor

slaweet commented May 10, 2017

I don't like that the names of services are capitalised. They are not instantiated with new. I'd rather have account, peers, ... then Account, Peers, ...

Some resources on that:
https://github.com/mgechev/angularjs-style-guide#services
http://luxiyalu.com/angular-best-practice-naming-conventions/

@reyraa
Copy link
Contributor Author

reyraa commented May 10, 2017

@slaweet The two resources you've linked are not using the same convention for services and factories. but I'm ok with cameCase.

@karmacoma karmacoma merged commit 3d568d1 into development May 10, 2017
@karmacoma karmacoma deleted the 179-angular-service-naming branch May 10, 2017 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants