This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Fix routing issues - Closes #180 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
reyraa
commented
May 8, 2017
reyraa
commented
- Redirect unknown routes to login page.
- Set the transactions tab as default tab of the main page.
- Redirect to landing page from login instead of main.
reyraa
changed the title
karmacoma
suggested changes
May 8, 2017
src/app/components/login/login.js
Outdated
| @@ -79,7 +78,7 @@ app.component('login', { | |||
| if (passphrase) { | |||
| this.input_passphrase = passphrase; | |||
| if (this.$rootScope.logged === undefined) { | |||
| this.$timeout(this.passConfirmSubmit.bind(this), 10); | |||
| // this.$timeout(this.passConfirmSubmit.bind(this), 10); | |||
| } | |||
There was a problem hiding this comment.
Why not remove whole if branch?
There was a problem hiding this comment.
I believe it's for development purposes. Just uncomment it and it does autologin. But it probably breaks logout.
There was a problem hiding this comment.
I guess it should be described in a comment in the file
karmacoma
approved these changes
May 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.