Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Move $peers service account-related methods to Account - Closes #169 #176

Merged
merged 7 commits into from
May 5, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented May 4, 2017

Expected behaviour

peers service should contain only code related to setting and maintaining a connection to a peer.

Actual behaviour

peers service contains definitions of the following methods that result in a server call:

  • listTransactions
  • getStatusPromise
  • sendLSKPromise
  • listTransactionsPromise
  • setSignature

All of them are related to an account, so they should be moved to another service: account

Closes #169

@slaweet slaweet added this to the Version 1.0.0 milestone May 4, 2017
@slaweet slaweet requested a review from karmacoma May 4, 2017 11:27
@slaweet slaweet force-pushed the 169_refactor-peers branch 2 times, most recently from 3028fbe to c538a18 Compare May 4, 2017 11:35
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 86.364% when pulling c538a18 on 169_refactor-peers into 99b6c1c on development.

@slaweet slaweet force-pushed the 169_refactor-peers branch from a346286 to 326b381 Compare May 4, 2017 13:12
@coveralls
Copy link

Coverage Status

Coverage increased (+2.3%) to 88.235% when pulling 326b381 on 169_refactor-peers into 99b6c1c on development.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.3%) to 88.235% when pulling 326b381 on 169_refactor-peers into 99b6c1c on development.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.3%) to 88.235% when pulling ffd5133 on 169_refactor-peers into 99b6c1c on development.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.8%) to 88.7% when pulling e017f5a on 169_refactor-peers into 99b6c1c on development.

@slaweet slaweet force-pushed the 169_refactor-peers branch 2 times, most recently from c856f04 to ffd5133 Compare May 4, 2017 15:09
@coveralls
Copy link

Coverage Status

Coverage increased (+2.3%) to 88.235% when pulling ffd5133 on 169_refactor-peers into 99b6c1c on development.

@karmacoma karmacoma modified the milestone: Version 1.0.0 May 5, 2017
@karmacoma karmacoma changed the title Move $peers service account-related methods to Account - #169 Move $peers service account-related methods to Account - Closes #169 May 5, 2017
@slaweet slaweet force-pushed the 169_refactor-peers branch from ffd5133 to 8d18079 Compare May 5, 2017 14:19
@coveralls
Copy link

Coverage Status

Coverage increased (+2.1%) to 88.018% when pulling 8d18079 on 169_refactor-peers into aeed7b2 on development.

@slaweet slaweet force-pushed the 169_refactor-peers branch from 8d18079 to 178aa20 Compare May 5, 2017 14:39
@coveralls
Copy link

Coverage Status

Coverage increased (+2.1%) to 87.461% when pulling 178aa20 on 169_refactor-peers into 597c535 on development.

@karmacoma karmacoma merged commit 184dd31 into development May 5, 2017
@karmacoma karmacoma deleted the 169_refactor-peers branch May 5, 2017 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants