This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 60
Move $peers service account-related methods to Account - Closes #169 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
169_refactor-peers
branch
2 times, most recently
from
May 4, 2017 11:35
3028fbe
to
c538a18
Compare
slaweet
force-pushed
the
169_refactor-peers
branch
from
May 4, 2017 13:12
a346286
to
326b381
Compare
slaweet
force-pushed
the
169_refactor-peers
branch
2 times, most recently
from
May 4, 2017 15:09
c856f04
to
ffd5133
Compare
karmacoma
changed the title
Move $peers service account-related methods to Account - #169
Move $peers service account-related methods to Account - Closes #169
May 5, 2017
slaweet
force-pushed
the
169_refactor-peers
branch
from
May 5, 2017 14:19
ffd5133
to
8d18079
Compare
slaweet
force-pushed
the
169_refactor-peers
branch
from
May 5, 2017 14:39
8d18079
to
178aa20
Compare
karmacoma
approved these changes
May 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behaviour
peers service should contain only code related to setting and maintaining a connection to a peer.
Actual behaviour
peers service contains definitions of the following methods that result in a server call:
All of them are related to an account, so they should be moved to another service: account
Closes #169