This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Refactor use of alert dialogs and toasts #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new service: dialog with methods: - toast - errorToast - successToast - alert - errorAlert - successAlert - modal and make sure they are used consistently across the codebase in order to ensure consistent UX
It was causing this issue: Warning: /Users/slaweet/git/lisk-nano/src/.eslintrc.json: Configuration for rule "no-param-reassign" is invalid: Value "data["0"].ignorePropertyModificationsFor" has additional properties.
karmacoma
approved these changes
May 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new service: dialog
With methods:
And make sure they are used consistently across the codebase in order to ensure consistent UX.