Support second passphrase - Closes #21 #145

reyraa · 2017-04-25T14:54:58Z

Breaks login component into a service, a directive and a component under the same name.
Reuses the created service to generate the second passphrase
Creates the relevant method on $peers service to register second passphrase
The styling of the button on main component is temporarily and will be merged into a dropdown menu after merging with other branches.

… x,y coordination object

…phrase service

…ce handles it

…quired modal views

…ve, - sets generated passphrase as second passphrase

…cond passphrase

coveralls · 2017-04-25T16:11:42Z

Coverage decreased (-3.3%) to 84.274% when pulling 919c727 on 21-support-second-passphrase into 625f7bd on development.

coveralls · 2017-04-26T10:40:09Z

Coverage decreased (-3.2%) to 84.401% when pulling e602f9e on 21-support-second-passphrase into 126b197 on development.

coveralls · 2017-04-26T13:25:08Z

Coverage decreased (-1.8%) to 85.761% when pulling c3ec49e on 21-support-second-passphrase into 126b197 on development.

karmacoma

Nice work @alihaghighatkhah. I've tested it and it works very well. I have only requested some changes to error messages and test descriptions.

karmacoma · 2017-04-26T10:23:45Z

src/app/components/main/setSecondPassDirective.js

+          if (err.message === 'Missing sender second signature') {
+            error.dialog({ text: 'You already have a second passphrase.' });
+          } else if (/^(Account does not have enough LSK)/.test(err.message)) {
+            error.dialog({ text: 'You don\'t have enought credit to register second passphrase.' });


You have insufficient funds to register a second passphrase.

karmacoma · 2017-04-26T10:24:50Z

src/app/components/main/setSecondPassDirective.js

+          } else if (/^(Account does not have enough LSK)/.test(err.message)) {
+            error.dialog({ text: 'You don\'t have enought credit to register second passphrase.' });
+          } else {
+            error.dialog({ text: 'An error happended registering your second passphrase. Please try later.' });


An error occurred while registering your second passphrase. Please try again later.

karmacoma · 2017-04-26T10:25:38Z

src/app/components/main/setSecondPassDirective.js

+    scope.passConfirmSubmit = (secondsecret) => {
+      $peers.active.setSignature(secondsecret, attrs.publicKey, attrs.passphrase)
+        .then(() => {
+          success.dialog('Your second passphrase is successfully registered.');


Your second passphrase was successfully registered.

karmacoma · 2017-04-26T10:28:17Z

src/test/components/main/setSecondPassDirective.spec.js

+  });
+
+  describe('SetSecondPassLink', () => {
+    it('Listens for broadcasting onAfterSignup', () => {


listens for an onAfterSignup event

karmacoma · 2017-04-26T10:37:03Z

src/app/components/main/secondPass.pug

@@ -0,0 +1,6 @@
+md-dialog.dialog-second(aria-label='Generate a second passphrase of your account')


Generate a second passphrase for your account

karmacoma · 2017-04-26T14:05:27Z

src/app/components/main/setSecondPassDirective.js

+          } else if (/^(Account does not have enough LSK)/.test(err.message)) {
+            text = 'You don\'t have enought credit to register second passphrase.';
+          } else {
+            text = 'An error happended registering your second passphrase. Please try later.';


An error occurred while registering your second passphrase. Please try again.

karmacoma · 2017-04-26T14:06:31Z

src/test/components/login/login.spec.js

-      const unbindSpy = sinon.spy(controller.$document, 'unbind');
-      controller.stopNewPassphraseGeneration();
-      expect(unbindSpy).to.have.been.calledWith('mousemove', controller.listener);
+    it('Listens for broadcasting onAfterSignup', () => {


listens for an onAfterSignup event

karmacoma · 2017-04-26T14:07:21Z

src/test/components/login/login.spec.js

-
-      mock.expects('get').returns(undefined);
+  describe('devTestAccount()', () => {
+    it('calls passConfirmSubmit with timeoout if a passphrase is set in the cookies', () => {


calls passConfirmSubmit with timeout if a passphrase is set in the cookies

karmacoma · 2017-04-26T14:07:59Z

src/test/components/login/passphrase.spec.js

+  });
+
+  describe('PassphraseLink', () => {
+    it('should asign progress to its own $scope', () => {


should assign progress to its own $scope

karmacoma · 2017-04-26T14:09:50Z

src/app/components/login/login.js

@@ -11,17 +8,21 @@ app.component('login', {
    onLogin: '&',
  },
  controller: class login {
-    constructor($scope, $rootScope, $timeout, $document, $mdDialog, $mdMedia, $cookies, $peers) {
+
+   /* eslint no-param-reassign: ["error", { "props": false }] */


Please fix indent.

coveralls · 2017-04-26T14:59:10Z

Coverage decreased (-1.8%) to 85.761% when pulling d114646 on 21-support-second-passphrase into 126b197 on development.

reyraa added 24 commits April 23, 2017 17:59

remove dependencies as they're not used in login component anymore

c9ce16b

create Passphrase service only handle passphrase generation for given…

543d101

… x,y coordination object

remove mdDialog since we'll use it in a separated directive, add Pass…

4963639

…phrase service

remove all the functions generating passphrase since Passphrase servi…

0e142e4

…ce handles it

import passphrase service to project

e5be5ea

import directives and factories of setting primary and second passphrase

23890ca

create a passphrase directive to use passphrase service and manage re…

ec9603a

…quired modal views

remove styles of mdDialogs

d07ffea

replace markups concerning passphrase with equivalent directives

f04eb07

create setSecondPass directive: - uses instanse of passphrase directi…

4805526

…ve, - sets generated passphrase as second passphrase

addapt tests according to changes in login.js

20aab5f

create setSecondPass service: uses mdDialog to show/hide modals of se…

4eca9a8

…cond passphrase

create unit tests for passphrase service

5a64ed0

unit test coverage for passphrase directive used in login page

41edf41

remove unnecessary comments

87408d8

import setSecondPass service to test modules

f776080

fix method names

f1fa111

increased test coverage in setSecondPass directive

c21af08

minor fixing

9d18e38

remove unused controller, fix the name of like function

0b5c832

restructure passphrase directive unit tests

d9981cc

hide second passphrase button if already set

403928b

add API call to set second passphrase, handle error messages

396cb1a

adapt tests accordingly

d0c529e

reyraa assigned reyraa and unassigned reyraa Apr 25, 2017

reyraa added the enhancement label Apr 25, 2017

reyraa added this to the Version 1.0.0 milestone Apr 25, 2017

reyraa assigned karmacoma Apr 25, 2017

minor fixins before digestion

0b94620

increate test converage

0ba7b65

karmacoma removed this from the Version 1.0.0 milestone Apr 25, 2017

Merge branch 'development' into 21-support-second-passphrase

919c727

karmacoma added the 🏗️ in progress label Apr 25, 2017

karmacoma changed the title ~~Support second passphrase, closes 21~~ Support second passphrase - Closes #21 Apr 26, 2017

Merge branch 'development' into 21-support-second-passphrase

e602f9e

reyraa added 3 commits April 26, 2017 14:03

tyding up a condition block

913d3af

increased test coverage

37d7c80

disable eslint for vriable usage as object parameter

c3ec49e

karmacoma suggested changes Apr 26, 2017

View reviewed changes

fix typos

d114646

karmacoma approved these changes Apr 26, 2017

View reviewed changes

karmacoma merged commit 61a9eed into development Apr 26, 2017

karmacoma deleted the 21-support-second-passphrase branch April 26, 2017 15:34

karmacoma removed the 🏗️ in progress label Apr 27, 2017

karmacoma removed bug chore enhancement refactoring test update labels Aug 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support second passphrase - Closes #21 #145

Support second passphrase - Closes #21 #145

reyraa commented Apr 25, 2017

coveralls commented Apr 25, 2017

coveralls commented Apr 26, 2017

coveralls commented Apr 26, 2017

karmacoma left a comment

karmacoma Apr 26, 2017

karmacoma Apr 26, 2017

karmacoma Apr 26, 2017

karmacoma Apr 26, 2017

karmacoma Apr 26, 2017

karmacoma Apr 26, 2017

karmacoma Apr 26, 2017 •

edited

Loading

karmacoma Apr 26, 2017 •

edited

Loading

karmacoma Apr 26, 2017 •

edited

Loading

karmacoma Apr 26, 2017

coveralls commented Apr 26, 2017

		@@ -0,0 +1,6 @@
		md-dialog.dialog-second(aria-label='Generate a second passphrase of your account')

Support second passphrase - Closes #21 #145

Support second passphrase - Closes #21 #145

Conversation

reyraa commented Apr 25, 2017

coveralls commented Apr 25, 2017

coveralls commented Apr 26, 2017

coveralls commented Apr 26, 2017

karmacoma left a comment

Choose a reason for hiding this comment

karmacoma Apr 26, 2017

Choose a reason for hiding this comment

karmacoma Apr 26, 2017

Choose a reason for hiding this comment

karmacoma Apr 26, 2017

Choose a reason for hiding this comment

karmacoma Apr 26, 2017

Choose a reason for hiding this comment

karmacoma Apr 26, 2017

Choose a reason for hiding this comment

karmacoma Apr 26, 2017

Choose a reason for hiding this comment

karmacoma Apr 26, 2017 • edited Loading

Choose a reason for hiding this comment

karmacoma Apr 26, 2017 • edited Loading

Choose a reason for hiding this comment

karmacoma Apr 26, 2017 • edited Loading

Choose a reason for hiding this comment

karmacoma Apr 26, 2017

Choose a reason for hiding this comment

coveralls commented Apr 26, 2017

karmacoma Apr 26, 2017 •

edited

Loading

karmacoma Apr 26, 2017 •

edited

Loading

karmacoma Apr 26, 2017 •

edited

Loading