Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Send through modal - Closes #88 #116

Merged
merged 16 commits into from
Apr 24, 2017
Merged

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented Apr 13, 2017

  • Move the transfer form from main view to a separated modal.
  • Create a directive with 2 optional parameters":
    • transferAmount
    • recipientId

We can use this directive to show transfer form with predefined recipient address or amount.

Closes #88

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 83.155% when pulling f8e2ce8 on 88-send-through-modal into a0cb4d7 on development.

@reyraa reyraa added this to the Version 1.0.0 milestone Apr 13, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 84.225% when pulling 3f4bb75 on 88-send-through-modal into a0cb4d7 on development.

@karmacoma karmacoma removed this from the Version 1.0.0 milestone Apr 13, 2017
@karmacoma karmacoma changed the title send through modal, closes #88 Send through modal - Closes #88 Apr 13, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+2.02%) to 86.631% when pulling 3119e34 on 88-send-through-modal into a0cb4d7 on development.

Copy link
Contributor

@karmacoma karmacoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work @alihaghighatkhah 👍

@coveralls
Copy link

coveralls commented Apr 20, 2017

Coverage Status

Coverage increased (+0.8%) to 87.908% when pulling 1d3e7f3 on 88-send-through-modal into babe4a0 on development.

@karmacoma
Copy link
Contributor

@alihaghighatkhah For some reason, 2 tests now failing. Will await your fix before merging.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 87.908% when pulling b00adef on 88-send-through-modal into babe4a0 on development.

@karmacoma karmacoma merged commit 0609407 into development Apr 24, 2017
@karmacoma karmacoma deleted the 88-send-through-modal branch April 24, 2017 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants