Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Some E2E tests were failing on Jenkins - Closes #1055 #1056

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Some E2E tests were failing on Jenkins - Closes #1055 #1056

merged 2 commits into from
Apr 17, 2018

Conversation

yasharAyari
Copy link
Contributor

@yasharAyari yasharAyari commented Apr 16, 2018 •
edited by slaweet
Loading

What was the problem?

Some E2E tests were failing on Jenkins

Review checklist

@yasharAyari yasharAyari self-assigned this Apr 16, 2018
@yasharAyari yasharAyari requested a review from slaweet April 16, 2018 12:33
slaweet
slaweet approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, Yashar.

@yasharAyari yasharAyari merged commit 51fee93 into 2.0.0 Apr 17, 2018
@yasharAyari yasharAyari deleted the 1055-some-e2e-tests-are-failing-on-jenkins branch April 17, 2018 07:40
@yasharAyari yasharAyari changed the title Add 'serve' script to node scripts and use it in jenkinsfile - Closes #1055 Some E2E tests were failing on Jenkins - Closes #1055 Apr 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slaweet slaweet slaweet approved these changes

Assignees

@yasharAyari yasharAyari

Labels
✅ ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasharAyari @slaweet