Fix autocomplete when changing a vote - Closes #990

[pouljohn1]

What was the problem?

Described here #990

How did I fix it?

Previously when we had toggled and untoggled specified vote, reducer state was with false state (vote.confirmed and vote.unconfirmed were false). I've changed it in a way that when user untoggled vote and state of this vote is unconfirmed I'm removing this vote from state, so final state is the same as initial state (before toggling vote).

How to test it?

Described here #990

Review checklist

• The PR solves Autocomplete changing a vote returns no matches for a valid delegate #990
• All new code is covered with unit tests
• All new code follows best practices

[reyraa]

We appreciate your participation. Please consider the following tweak. in src/utils/api/delegate.js#L26, apply this change:

return new Promise((resolve, reject) =>
    listDelegates(activePeer, options)
      .then((response) => {
        resolve(response.delegates.filter(delegate =>
          Object.keys(votedDict).filter(item =>
            (item === delegate.username) && (item.confirmed || item.unconfirmed)).length === 0,
        ));
      })
      .catch(reject),
  );

I've added item.confirmed || item.unconfirmed to the condition and it fixes the issue.

[pouljohn1]

It was my first attempt, but for me it is more like hack. As I understand state like !unconfirmed and !confirmed should not happen (what does it mean than?) - for me it should be either confirmed or unconfirmed.
My approach results the same state as it was before toggling vote on which I think is a good approach.

But of course I don’t know whole code so maybe missing something. If you want I could change to this.

[slaweet]

I see that the usage of unconfirmed and confirmed is not very clear.

• unconfirmed says if the delegate is selected or not in the app.
• confirmed says if the delegate is selected or not on the blockchain.

!unconfirmed and !confirmed means that the delegate selected neither in the app nor on the blockchain.

As @reyraa mentioned the bug can be fixed with much fewer changes in this function:
https://github.com/LiskHQ/lisk-nano/blob/32cc92608f5c6c72dacf1f286d267ac2111a7943/src/utils/api/delegate.js#L26-L35

[pouljohn1]

I get this, but still I think that such vote should not be in reducer (it means the same). For me this reducer needs some refactor, it is too much error prone.
But for not making too much changes I will do the way that you told

[slaweet]

The proposed solution was implemented in #1074 so closing this one.