Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Fix login page after-migration differences #624

Closed
slaweet opened this issue Aug 21, 2017 · 1 comment · Fixed by #673
Closed

Fix login page after-migration differences #624

slaweet opened this issue Aug 21, 2017 · 1 comment · Fixed by #673

Comments

@slaweet
Copy link
Contributor

slaweet commented Aug 21, 2017

Expected behaviour

Login should work like before the migration.

Actual behaviour

There are these differences:

  • Allows to log in to an offline custom node
  • Doesn’t have the “Check for new version” error if API responds with 404
  • Some elements are centered instead of left-aligned: Items in network dropdown, error messages on address and passphrase inputs
  • Marks URLs with default ports as "Invalid", e.g. http://node03.lisk.io:80 or https://node03.lisk.io:443 Also if the ports are not specified at all.
@slaweet slaweet changed the title Fix login tab after-migration differences Fix login page after-migration differences Aug 24, 2017
@slaweet
Copy link
Contributor Author

slaweet commented Aug 24, 2017

This is the old code for “Check for new version” error if API responds with 404:
https://github.com/LiskHQ/lisk-nano/blob/bb27b7470cc739390e6f9744e0e46d705272d9a7/src/services/api/peers.js#L118-L126

And this is the original issue: #309

slaweet added a commit that referenced this issue Aug 29, 2017
Fix login page after-migration differences - Closes #624
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants