Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Conformity between modals #294

Closed
maxkordek opened this issue May 31, 2017 · 1 comment
Closed

Conformity between modals #294

maxkordek opened this issue May 31, 2017 · 1 comment

Comments

@maxkordek
Copy link

Expected behaviour

The left "button" should always say "CANCEL" and should never be a stylistic button but rather only the text, when you hover it transforms into a button.

The right button should (nearly) always say the action and should always be a stylist button, never text.

-> You move the attention to the actionable buttons, away from "noise" in the UI.

Modal overview:

SEND:

  • CANCEL (make it text only, with hover button)
  • SEND (stays as it is)

VOTE:

  • CANCEL (stays as it is)
  • CONFIRM VOTE (make it a stylistic button)

SIGN/VERIFY MESSAGE:

  • Add a CANCEL button (make it text only, with hover button)

SAVE PASSPHRASE: PART 1

  • CLOSE->CANCEL (rename, else stays as it is)
  • YES! IT'S SAFE! (make it a stylistic button)

SAVE PASSPHRASE: PART 2

  • CLOSE->BACK (rename, add functionality to go back to the passphrase)
  • OK->LOGIN (rename, make it a stylistic button)

GENERATE 2nd PASSPHRASE: PART 1

  • CLOSE->CANCEL (rename, else stays as it is)
  • YES! IT'S SAFE! (make it a stylistic button)

GENERATE 2nd PASSPHRASE: PART 2

  • CLOSE->BACK (rename, add functionality to go back to the passphrase)
    OK->REGISTER (rename, make it a stylistic button)

DELEGATE REGISTRATION:

  • CANCEL (make it a text only, with hover button)
  • REGISTER (stays as it is)

Actual behaviour

The left button sometimes says "CLOSE", sometimes "CANCEL". Also it's sometimes a stylistic button and sometimes only text. See for yourself, it's totally not consistent right now.

Steps to reproduce

Open the modals.

@maxkordek
Copy link
Author

Conformity part 2

Expected behaviour

All modals have an "X" button in the top-right corner. I know that this is duplicated with the Cancel button, but this is not a problem. (Windows and macOS have this very often too) We can't have sometimes the X and sometimes the Cancel button. Always both.

Actual behaviour

Some modals don't have it.

Steps to reproduce

The following modals don't have it:

  • Send
  • Generate a second passphrase of your account
  • Save your passphrase in a safe place (1st and 2nd pass)
  • Enter the missing word to continue (1st and 2nd pass)
  • Delegate registration
  • Vote for delegates

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants